Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usecases: port to android #7695

Merged
merged 5 commits into from
Feb 22, 2025
Merged

usecases: port to android #7695

merged 5 commits into from
Feb 22, 2025

Conversation

FloVanGH
Copy link
Member

  • usescases demo can no be run on android
  • the sidebar of the mail example is now responsive (can be open as popup on portrait mode)
  • builtin osk is hidden on android

I want to make use of material style for the usecase demo on android in an upcoming PR.

@FloVanGH FloVanGH force-pushed the florian/usecases-android branch from cd3af52 to 6f31071 Compare February 21, 2025 15:27
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
I tried it on android and it kind of works, but there is some issues:

  • I'd say it should use the material style on android (we should change the build.rs to use the material style depending on the TARGET_OS, instead of cosmic)
  • The hamburger menu only applies to the "mail" tab, but the side bar comes over the tab. But I guess that's OK.
  • Trying to fill the reply text edit doesn't work. the keyboard disapear as soon as you start typing. Probably a bug in Slint.

Overall, I think this is a good design. So this should be merged for now.
Too bad that it still has bug or exposes Slint bugs

@FloVanGH
Copy link
Member Author

Nice work! I tried it on android and it kind of works, but there is some issues:

* I'd say it should use the material style on android (we should change the build.rs to use the material style depending on the TARGET_OS, instead of cosmic)

* The hamburger menu only applies to the "mail" tab, but the side bar comes over the tab. But I guess that's OK.

* Trying to fill the reply text edit doesn't work. the keyboard disapear as soon as you start typing. Probably a bug in Slint.

Overall, I think this is a good design. So this should be merged for now. Too bad that it still has bug or exposes Slint bugs

Thabk you. My plan is to do the material style in the next pr. You're right. The menu should only visible on the mail view.

@FloVanGH FloVanGH merged commit 48ae567 into master Feb 22, 2025
39 checks passed
@FloVanGH FloVanGH deleted the florian/usecases-android branch February 22, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants