Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional lux status codes #61

Merged
merged 2 commits into from
Aug 19, 2023
Merged

feat: add additional lux status codes #61

merged 2 commits into from
Aug 19, 2023

Conversation

marksie1988
Copy link
Contributor

@marksie1988 marksie1988 commented Aug 19, 2023

Description

A small patch to add additional status codes for Lux inverters

Related issues

closes #60

Motivation and Context

Allows more cover for status codes in the Lux inverter.

How has this been tested

I have tested this locally but cant fully test the state codes until they occur

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated the version in package.json following semver

@marksie1988 marksie1988 changed the title patch: add additional lux status codes feat: add additional lux status codes Aug 19, 2023
@slipx06 slipx06 merged commit eca8f02 into slipx06:master Aug 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lux Status Code Missing?
2 participants