fix: typo for cleanUrls: true on Vercel
#12
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@styfle is attempting to deploy a commit to the Trailing Slash Team Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks The results on my existiung test deployment are different surprisingly: 
I'm not sure how generated those deployments anymore, maybe I did a typo in the config while deploying this deployment in particular. Is there any way on your side to check the config I used on my deployment? If that helps: https://vercel.com/trailing-slash-team/vercel-cleanurls-true-trailingslash-undefined I don't see any vercel.json on my source, so maybe I used the UI settings? Is this still possible (or has ever been?) to set this config through the UI settings tab? |
|
Ohhh I remember now: I used one branch per The appropriate branch: https://github.com/slorber/trailing-slash-guide/blob/vercel-cleanurls-true-trailingslash-undefined/static/vercel.json It looks wired correctly:
Note I explicitly use This is really weird, my deployment shows a preview screenshot that looks like your results, but it's not what I see in practice after navigating to this deployment locally! https://vercel.com/trailing-slash-team/vercel-cleanurls-true-trailingslash-undefined shows: 
And this other url https://vercel.com/trailing-slash-team/vercel-cleanurls-true-trailingslash-undefined/3Xw7ZAyiKSbZwFawchhK9k1f8nAb shows: 
Edit: damn, I refreshed the deployment URL https://vercel.com/trailing-slash-team/vercel-cleanurls-true-trailingslash-undefined and now the screenshot changed! 
|
|
This looks like a typo too: It has the string That might explain why that commit failed to deploy. I created another PR with the fix: |
|
@slorber Can you approve the deployments in both these PRs to confirm that the previews work as expected now? |
|
Ahhh 🤯 good catch! Thanks, that now works! https://vercel-cleanurls-true-trailingslash-undefined.vercel.app/
Not exactly the results you updated in this PR: we still have some server redirects (expected IMHO) Also: I updated both deployments with Also, the table is displayed there too: https://github.com/slorber/trailing-slash-guide/blob/main/docs/Hosting-Providers.md Normally the full Markdown table is automatically generated with code in the console if you go on the deployment index: https://vercel-cleanurls-true-trailingslash-undefined.vercel.app/ It seems they shut down the CORS proxy I was using: https://github.com/slorber/trailing-slash-guide/blob/main/static/index.html#L202 I can fix it so that we don't have to manually edit the Markdown table, but do you know a good free CORS proxy I could rely on? |
You could try this one: https://github.com/josmas/vercel-proxy |
|
Probably not the most robust CORS impl but it seems to work:
Will try to update it on this repo tomorrow 👍 |
|
Table regeneration fixed 👍 thanks for the fix |
|
@slorber What do you think about removing one of these rows since "Default" and ( 
Docs: https://vercel.com/docs/concepts/projects/project-configuration |
|
👍 simplified/deduplicated for Vercel + Netlify 
|
I tested this this by deploying with
{ "cleanUrls": true }. I think this was just a typo in the readme.