health_spec test includes coverage for negative scenarios, modified t…

…he index of health_controller

app/controllers/health_controller.rb

@@ -3,10 +3,12 @@ class HealthController < ApplicationController
   def index
     database_check_results = check_db_connections
     if all_database_healthy?(database_check_results)
-      render json: {status: "ok", databases: database_check_results}, status: :ok
+      render json: {status: "ok"}, status: :ok
     else
-      render json: {status: "error", databases: database_check_results}, status: :internal_server_error
+      render json: {status: "fail"}, status: :internal_server_error
     end
+  rescue StandardError
+    render json: {status: "fail"}, status: :internal_server_error
   end
 
   private
@@ -36,9 +38,7 @@ def perform_health_check(connection)
       connection.execute('SELECT 1')
       {status: 'ok'}
     else
-      {status: 'error', message: 'Connection not established'}
+      {status: 'fail'}
     end
-  rescue => e
-    {status: 'error', message: e.message}
   end
 end

spec/features/health_spec.rb

@@ -1,15 +1,50 @@
 require 'rails_helper'
 
 RSpec.feature "Healthcheck", type: :feature do
-  scenario 'As a healthcheck bot I want to check if everything is ok' do
-    visit health_path
+  context 'when healthcheck passes' do
+    scenario 'With healthcheck I want to check if everything is ok' do
+      visit health_path
 
-    expect(page.status_code).to be(200)
+      expect(page.status_code).to be(200)
 
-    returned_data = JSON.parse(page.body)
+      returned_data = JSON.parse(page.body)
 
-    expect(returned_data["status"]).to eq("ok")
-    expect(returned_data["databases"]["primary"]).to include("status" => "ok")
-    expect(returned_data["databases"]["datahub"]).to include("status" => "ok")
+      expect(returned_data["status"]).to eq("ok")
+    end
+  end
+
+  context 'when healthcheck fails' do
+    scenario 'unexpected error in health check' do
+      allow_any_instance_of(HealthController).to receive(:all_database_healthy?).and_raise(StandardError, 'Unexpected error')
+
+      visit health_path
+
+      expect(page.status_code).to be(500)
+      returned_data = JSON.parse(page.body)
+
+      expect(returned_data["status"]).to eq("fail")
+    end
+
+    scenario 'primary database fails' do
+      allow(ApplicationRecord.connection).to receive(:execute).and_raise(StandardError, 'Something went wrong in primary db')
+
+      visit health_path
+
+      expect(page.status_code).to be(500)
+      returned_data = JSON.parse(page.body)
+
+      expect(returned_data["status"]).to eq("fail")
+    end
+
+    scenario 'datahub database fails' do
+      allow(DatahubRecord.connection).to receive(:execute).and_raise(StandardError, 'Something went wrong in datahub db')
+
+      visit health_path
+
+      expect(page.status_code).to be(500)
+      returned_data = JSON.parse(page.body)
+
+      expect(returned_data["status"]).to eq("fail")
+    end
   end
 end