Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker files and build instructions #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Granjow
Copy link
Member

@Granjow Granjow commented May 20, 2024

Related: #3

@Granjow Granjow self-assigned this May 20, 2024
@Granjow Granjow changed the title WIP: Add docker files and build instructions Add docker files and build instructions May 23, 2024
@Granjow
Copy link
Member Author

Granjow commented May 23, 2024

@JJones780 – do you want to review this and check if the docker build works for you if you follow the readme?

@JJones780
Copy link

My internet isn't the fastest so I don't use docker very often.
My Docker didn't recognize -name . I had to use -t instead
after running the second docker command I'm getting an error
"/bin/sh: 0: cannot open ./build.sh: No such file"

I'm out of practice with Docker... so it isn't obvious to me how the v3d-flow source is supposed be accessed from the running docker instance?

@Granjow
Copy link
Member Author

Granjow commented May 23, 2024

Thanks for testing! Right, the -name was wrong indeed.

Did you use the volume mount (-v …)? That is the command which mounts your current directory (which should be the repo root) into the docker container, and also how the compiled binary is copied back.

@JJones780
Copy link

Yes, used the command as written in the Readme with the -v option.
I don't see any build.sh script in the repo root.
I didn't do the submodule update or any steps in the section above... I assume that's what the build.sh will do once I get it?

@Granjow
Copy link
Member Author

Granjow commented May 26, 2024

@JJones780 My bad – It was ignored because of the .gitignore file. Now it should work!

No, the build.sh does not update submodules, it only runs cmake/make :)

@JJones780
Copy link

I built using docker successfully.

tried running it and got this:
./slowmoFlowBuilder: error while loading shared libraries: libjpeg.so.8: cannot open shared object file: No such file or directory
whereas running the one I compiled without docker had no problems.

I hope you can keep the docker image small... it's practical.

@Granjow
Copy link
Member Author

Granjow commented May 27, 2024

Thanks for testing. What OS are you on atm.? You need the same as in the docker image, otherwise it may fail to find shared libraries.

@JJones780
Copy link

I'm running Devuan daedalus which should have the same libjpeg as Debian 12 ( Bookworm).
I've got libjpeg62-turbo-dev which solves this issue in similar cases but not here.

A common solution mention on the 'net is to create a symlink:
sudo ln -s /usr/lib/x86_64-linux-gnu/libjpeg.so.62 /usr/lib/x86_64-linux-gnu/libjpeg.so.8

which still gets an error:
./slowmoFlowBuilder: /usr/lib/x86_64-linux-gnu/libjpeg.so.8: version `LIBJPEG_8.0' not found (required by ./slowmoFlowBuilder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants