Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Fix license comments #325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beatrycze-volk
Copy link
Contributor

No description provided.

@beatrycze-volk beatrycze-volk added the 🛠️ maintenance A task to keep the code up-to-date and manageable. label Dec 2, 2024
@beatrycze-volk beatrycze-volk added this to the DFG-Viewer 6.2.0 milestone Dec 2, 2024
@beatrycze-volk beatrycze-volk self-assigned this Dec 2, 2024
@stweil
Copy link
Contributor

stweil commented Dec 2, 2024

As far as I know the DFG Viewer is licensed by GPL 3. This pull request relaxes the license by adding GPL 2 to files which did not have a license statement or by changing an existing license statement from GPL 3 to GPL 2.

I don't think that such changes are compatible with the license requirements.

In addition, the PR changes copyright comments. Unless the old comments were wrong, this can be considered bad style or even not allowed.

@beatrycze-volk
Copy link
Contributor Author

As far as I know the DFG Viewer is licensed by GPL 3. This pull request relaxes the license by adding GPL 2 to files which did not have a license statement or by changing an existing license statement from GPL 3 to GPL 2.

In the files there is no change from 3 to 2. The old version of the text also contains number 2. The only change is the copyright comment.

I don't think that such changes are compatible with the license requirements.

In addition, the PR changes copyright comments. Unless the old comments were wrong, this can be considered bad style or even not allowed.

The DFG Viewer is developed by many developers but in the copyright notice were only mentioned the first ones. The code base itself is managed by the SLUB so this change looks like the one which corrects to the factual state.

* This script is part of the TYPO3 project. The TYPO3 project is
* free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the files there is no change from 3 to 2.

Is this here (and several more) no change from 3 to 2?

@stweil
Copy link
Contributor

stweil commented Dec 2, 2024

The DFG Viewer is developed by many developers but in the copyright notice were only mentioned the first ones. The code base itself is managed by the SLUB so this change looks like the one which corrects to the factual state.

Most old copyrights are for SLUB developers, so a change from individual to an organisational copyright can be done.
But what about the other copyrights which were for Kitodo e. V.? Where did they come from? Were they wrong? If not, it might be better to simply keep them and add a 2nd copyright for SLUB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ maintenance A task to keep the code up-to-date and manageable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants