-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix markdown link action fail #2480
base: main
Are you sure you want to change the base?
Conversation
@jbampton Can you please review this and suggest me changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit
is failing at the install step so we can't check if this addition works.
And we also know there are some broken links still.
Seems we need to fix the pre-commit run first. Can be another pr
The pre-commit failure is seen here https://github.com/slurpcode/slurp/actions/runs/7022977508/job/19108441822?pr=2480
Is the failure an issue with Python or Pylint ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can test your work locally by just running the hook you added: "markdown-link-check"
Test with:
pre-commit run markdown-link-check --all-files
a reminder |
…lurp into fix-markdown-link-action-fail
this pr is draft so close? |
Conflicting files |
The PR labeler is now working again |
? |
closing? |
No description provided.