[Encryption] REST Integration #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 13, 2024 15:04
smaheshwar-pltr
changed the base branch from
main
to
hive-fixes-and-spark-rest-merge
smaheshwar-pltr
changed the title
smaheshwar-pltr
commented
Nov 14, 2024
Comment on lines
+70
to
78
| { | ||
| SparkCatalogConfig.REST.catalogName(), | ||
| SparkCatalogConfig.REST.implementation(), | ||
| appendCatalogEncryptionProperties( | ||
| ImmutableMap.<String, String>builder() | ||
| .putAll(SparkCatalogConfig.REST.properties()) | ||
| .put(CatalogProperties.URI, restCatalog.properties().get(CatalogProperties.URI)) | ||
| .build()) | ||
| } |
There was a problem hiding this comment.
For some reason, three tests run for each test but I've only specified two parameters here.
smaheshwar-pltr
changed the title
smaheshwar-pltr
commented
Jan 19, 2025
| @@ -122,7 +133,33 @@ public void testInsertAndDelete() { | |||
| } | |||
|
|
|||
| @TestTemplate | |||
| public void testDirectDataFileRead() { | |||
| public void testDirectUnencryptedDataFileRead() { | |||
There was a problem hiding this comment.
TODO: Remove changes to this file. Hive PR's test should suffice. Make ORDER BY change there.
smaheshwar-pltr
force-pushed
the
v1-rest-encryption
branch
from
fe3230d to
31fa050
Compare
smaheshwar-pltr
commented
Jan 19, 2025
|
|
||
| @Disabled("Fails with `java.lang.IllegalStateException: Null key metadata buffer`") | ||
| @TestTemplate | ||
| public void testCtas() { |
There was a problem hiding this comment.
Why does this not work?
smaheshwar-pltr
force-pushed
the
v1-rest-encryption
branch
from
31fa050 to
c3440a9
Compare
smaheshwar-pltr
commented
Jan 19, 2025
| .collect(Collectors.toList()), | ||
| discardChanges ? ImmutableList.of() : ImmutableList.copyOf(changes)); | ||
|
|
||
| result.setKekCache(kekCache); |
There was a problem hiding this comment.
Maybe add as a constructor parameter instead of doing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base is #6. WIP.