Fix: Open Chat instruction selects range of code in active editor #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return contentMsg | ||
| .replace("%CURRENT_FILE%", relativePath?.toString() ?: filePath.toString()) | ||
| .replace("%CURSOR_LINE%", line1.toString()) | ||
| .replace("%CODE_SELECTION%", text) | ||
| } | ||
|
|
||
| @OptIn(DelicateCoroutinesApi::class) |
There was a problem hiding this comment.
Interesting, is DelicateCoroutinesApi OptIn?
There was a problem hiding this comment.
Is there any other way to implement setTimeout functionality? Without that, sometimes chat is not ready yet and file is not getting attached
There was a problem hiding this comment.
OptIn was kindly suggested by IDE when I tried to use GlobalScope.launch :)
There was a problem hiding this comment.
By the way, changed GlobalScope to CoroutineScope, now we should be fine
There was a problem hiding this comment.
Timer().schedule(500) {
val pos1 = LogicalPosition(line1, 0)
val pos2 = LogicalPosition(line2, editor.document.getLineEndOffset(line2))
editor.selectionModel.setSelection(
editor.logicalPositionToOffset(pos1),
editor.logicalPositionToOffset(pos2)
)
}Might work
There was a problem hiding this comment.
Is CoroutineScope undesirable?
There was a problem hiding this comment.
I think it should be fine since we use coroutines else where :)
MarcMcIntosh
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic of lines selection in active editor's tab, if
contentMsgis empty (no messages were provided)