Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dec 20 tele fix #49

Merged
merged 14 commits into from
Dec 29, 2023
Merged

dec 20 tele fix #49

merged 14 commits into from
Dec 29, 2023

Conversation

valaises
Copy link
Contributor

No description provided.

@valaises valaises requested a review from olegklimov December 20, 2023 18:01
* fixed enormous amount of human characters in telemetry
* human characters after last completion made no longer counts, as this lead to bugs
* telemetry_full_cycle -> 2 functions (request from @oleg)
@valaises valaises requested a review from olegklimov December 25, 2023 11:20
@valaises valaises self-assigned this Dec 26, 2023
@valaises valaises added bug Something isn't working blocker labels Dec 26, 2023
@valaises valaises requested a review from reymondzzzz December 27, 2023 16:39
src/telemetry/utils.rs Outdated Show resolved Hide resolved
@valaises valaises requested a review from olegklimov December 27, 2023 22:50

for s in &mut text_a_lines {
*s = s.trim_end().trim_start();
// info!("text_a: {}; len: {}", s, s.len());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if u not sure, use debug!() macros. I will add extra param for debug lvl https://docs.rs/tracing/latest/tracing/macro.debug.html


for s in &mut text_b_lines {
*s = s.trim_end().trim_start();
// info!("text_b: {}; len: {}", s, s.len());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same


let (added_characters, _) = utils::get_add_del_chars_from_texts(&removed_characters, &added_characters);

// let real_characters_added = re.replace_all(&added_characters, "").len() as i64 - re.replace_all(&removed_characters, "").len() as i64;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra comments

let key = (accum.file_extension.clone(), accum.model.clone());
unique_combinations.entry(key).or_default().push(accum);
}
let mut compressed_vec= vec![];
for (key, entries) in unique_combinations {
info!("compress_robot_human: compressing {} entries for key {:?}", entries.len(), key);
// info!("compress_robot_human: compressing {} entries for key {:?}", entries.len(), key);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with debug!

@valaises valaises requested a review from olegklimov December 29, 2023 11:49
@valaises valaises merged commit 7f79ea1 into main Dec 29, 2023
9 checks passed
@valaises valaises deleted the dec20-tele-fix branch December 29, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants