设置边沿触发 #1
Open
设置边沿触发 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallnest
reviewed
Jun 24, 2019
| @@ -33,7 +33,8 @@ func MkEpoll() (*epoll, error) { | |||
| func (e *epoll) Add(conn net.Conn) error { | |||
| // Extract file descriptor associated with the connection | |||
| fd := socketFD(conn) | |||
| err := unix.EpollCtl(e.fd, syscall.EPOLL_CTL_ADD, fd, &unix.EpollEvent{Events: unix.POLLIN | unix.POLLHUP, Fd: int32(fd)}) | |||
| //默认是水平触发，这样在未得到处理之前会不断被触发放到workpoll,需要设置为边沿触发 | |||
| err := unix.EpollCtl(e.fd, syscall.EPOLL_CTL_ADD, fd, &unix.EpollEvent{Events: unix.POLLIN | unix.POLLHUP | unix.EPOLLET, Fd: int32(fd)}) | |||
| if err != nil { | |||
There was a problem hiding this comment.
这里特意设置成水平触发，这样消息未完全读完的情况下，还有机会继续被读取，避免hang住的情况
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.