Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate equals and hashcode for @ConfigMapping implementations #1181

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Generate equals and hashcode for @ConfigMapping implementations #1181

merged 1 commit into from
Jun 27, 2024

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jun 21, 2024 •
edited
Loading

Consider whether we should generate equals and hashCode by default. Right now, it always generates. Alternatively, we could mandate the equals and hashcode methods in the mapping interface to trigger the generation.

ia3andy
ia3andy approved these changes Jun 25, 2024
View reviewed changes
Copy link

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radcortez 😍

@radcortez radcortez merged commit f56ac09 into smallrye:main Jun 27, 2024
8 checks passed
@github-actions github-actions bot added this to the 3.8.4 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

Add the ability to generate equals and hashcode for @ConfigMapping
2 participants
@radcortez @ia3andy