Makes EnvName mutable to avoid allocating it for lookups #1295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1294 I've discovered two interesting things:
EnvName::hashCode
(which is compute intensive) it's performed twice due to a mix of ifget == null
,put
: here I've enabled hashCode caching, despite it makesEnvName
a bit fatter i.e. 24 bytes vs 16 :"(EnvName
is created multiple times on the fly, to perform matching - without ever storing it (!). And most of the times these are misses: I've than allow it to be mutable to avoid keeping on allocating them