Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DefaultValuesConfigSource #993

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Improve DefaultValuesConfigSource #993

merged 1 commit into from
Sep 7, 2023

Conversation

radcortez
Copy link
Member

No description provided.

@radcortez radcortez merged commit 0e16f59 into smallrye:main Sep 7, 2023
6 checks passed
@github-actions github-actions bot added this to the 3.4.0 milestone Sep 7, 2023
@dmlloyd
Copy link
Contributor

dmlloyd commented Sep 8, 2023

What's the improvement?

@radcortez
Copy link
Member Author

We noticed some allocation activity on each lookup due to the search in the KeyMap, because of getNextSegment (which I'm algo looking to improve).

In this case, we don't really need to pay the cost of storing all the defaults in the KeyMap, so the idea is that a plain name is stored in a simple Map and wildcard defaults are stored in the KeyMap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@radcortez @dmlloyd