rewrite the core implementation and introduce a 2nd version of the programmatic API #1077
+10,416
−6,249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Action` interface is basically a `Runnable` whose `run` method declares a checked exception of type `Exception`. It is generally useful in more tests than just timing tests.
This has never been used and there's no need to keep it anymore.
…tions This usually consists of dropping the old synchronous implementation and renaming and adapting the old asynchronous implementation (`CompletionStage*`). Some of the new implementations still contain extra code for handling synchronous interrupts, mainly to keep all unit tests passing. The pseudo-async invocations (methods returning `java.util.concurrent.Future`) still have a few dedicated strategies (`FutureExecution`, `FutureTimeout`), but those are not supported in the programmatic API, which will benefit most from this unification. This commit also renames `InvocationContext` to `FaultToleranceContext` and `InvocationContextEvent` to `FaultToleranceEvent`.
This includes the `Guard` and `TypedGuard` types, together with the `@ApplyGuard` interceptor binding annotation. These types unify synchronous and asynchronous invocations, using the new fault tolerance strategies introduced earlier. The `Guard` and `TypedGuard` interfaces, as well as their implementations, currently experience rather heavy code duplication; this can be solved in the future (probably by generating the code from a template). The first version of the programmatic API (`FaultTolerance` and `@ApplyFaultTolerance`) continues to exist, but is deprecated for removal. It will be removed in SmallRye Fault Tolerance 7.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #796