Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve record accessor method names, update CI for Java 17/21 #1655

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Preserve record accessor method names, update CI for Java 17/21 #1655

merged 7 commits into from
Dec 5, 2023

Conversation

MikeEdgar
Copy link
Member

@MikeEdgar MikeEdgar commented Nov 22, 2023 •
edited
Loading

Fixes #1631

  • Update CI to use Java 17 + 21 build matrix (build release w/Java 17, run TCK w/Java 11)
  • Bumps Gradle to 8.5 (to support Java 21)

@MikeEdgar MikeEdgar added this to the 3.7.1 milestone Nov 22, 2023
@MikeEdgar MikeEdgar force-pushed the issue-1631 branch 2 times, most recently from 1d90084 to c5d137e Compare November 22, 2023 00:11
phillip-kruger
phillip-kruger previously approved these changes Nov 22, 2023
View reviewed changes
@MikeEdgar MikeEdgar marked this pull request as draft November 23, 2023 12:31
@MikeEdgar MikeEdgar force-pushed the issue-1631 branch 4 times, most recently from 1aa2902 to 545ef65 Compare November 24, 2023 00:40
@MikeEdgar
Copy link
Member Author

I hope to get back to this later this week. The Quarkus Maven plugin build mojo doesn't support toolchains, so I'm looking at alternate approaches to getting this to work nicely with the CI.

@MikeEdgar
Copy link
Member Author

@radcortez , @phillip-kruger - with both Quarkus and Wildfly moving to JDK 17 very soon, are there any qualms about dropping JDK 11 (and adding 21) from the CI here? We can continue to create JDK 8 compatible artifacts, but using JDK 17 as the minimum in CI would help avoid doing extra gymnastics to get the embedded test application building in JDK <17.

@phillip-kruger
Copy link
Member

+1

@MikeEdgar MikeEdgar marked this pull request as ready for review December 5, 2023 20:48
@MikeEdgar MikeEdgar requested a review from a team as a code owner December 5, 2023 20:48
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@MikeEdgar
Copy link
Member Author

Finally got this working with a Java 17 + 21 build matrix. @phillip-kruger can you please take another look before I merge this?

@MikeEdgar MikeEdgar changed the title Preserve record accessor method names, build test data with JDK 17 Preserve record accessor method names, update CI for Java 17/21 Dec 5, 2023
phillip-kruger
phillip-kruger approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeEdgar MikeEdgar merged commit 215d329 into smallrye:main Dec 5, 2023
7 checks passed
@MikeEdgar MikeEdgar deleted the issue-1631 branch December 5, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-kruger phillip-kruger phillip-kruger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Duplicate properties when (not) using bean convention
2 participants
@MikeEdgar @phillip-kruger