Skip to content

Commit

Permalink
SROTEL-428 - LogRecordExporter is created using incorrect service name (
Browse files Browse the repository at this point in the history
#429)

Add constant for log service name
Update LogRecordExporter creation to use correct service name
  • Loading branch information
jasondlee authored Jan 2, 2025
1 parent 6b2dfa6 commit c2d5de9
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public LogRecordExporter createExporter(ConfigProperties config) {
final String protocol = getProtocol(config, getSignalType());

if (PROTOCOL_GRPC.equals(protocol)) {
return new VertxGrpcLogsExporter(createGrpcExporter(config, VertxGrpcSender.GRPC_TRACE_SERVICE_NAME));
return new VertxGrpcLogsExporter(createGrpcExporter(config, VertxGrpcSender.GRPC_LOG_SERVICE_NAME));
} else if (PROTOCOL_HTTP_PROTOBUF.equals(protocol)) {
return new VertxHttpLogsExporter(createHttpExporter(config, VertxHttpSender.LOGS_PATH));
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public final class VertxGrpcSender<T extends Marshaler> implements GrpcSender<T>

public static final String GRPC_TRACE_SERVICE_NAME = "opentelemetry.proto.collector.trace.v1.TraceService";
public static final String GRPC_METRIC_SERVICE_NAME = "opentelemetry.proto.collector.metrics.v1.MetricsService";
public static final String GRPC_LOG_SERVICE_NAME = "opentelemetry.proto.collector.logs.v1.LogsService";
private static final String GRPC_METHOD_NAME = "Export";

private static final String GRPC_STATUS = "grpc-status";
Expand Down

0 comments on commit c2d5de9

Please sign in to comment.