Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply DLQ strategy on deserialization failure #2256

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

ozangunalp
Copy link
Collaborator

From doc change:

If the fail-on-deserialization-failure attribute is set to false and the failure-strategy attribute is dead-letter-queue the failed record will be sent to the corresponding dead letter queue topic. The forwarded record will have the original key and value, and the following headers set:

  • deserialization-failure-reason: The deserialization failure message
  • deserialization-failure-cause: The deserialization failure cause if any
  • deserialization-failure-key: Whether the deserialization failure happened on a key
  • deserialization-failure-topic: The topic of the incoming message when a deserialization failure happen
  • deserialization-failure-deserializer: The class name of the underlying deserializer
  • deserialization-failure-key-data: If applicable the key data that was not able to be deserialized
  • deserialization-failure-value-data: If applicable the value data that was not able to be deserialized

@ozangunalp
Copy link
Collaborator Author

@vsevel this may be of interest to you.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #2256 (b7ac8dc) into main (83bedaa) will increase coverage by 0.07%.
Report is 2 commits behind head on main.
The diff coverage is 87.50%.

❗ Current head b7ac8dc differs from pull request most recent head 0c8ee76. Consider uploading reports for the commit 0c8ee76 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2256      +/-   ##
============================================
+ Coverage     77.87%   77.95%   +0.07%     
- Complexity     3705     3713       +8     
============================================
  Files           301      302       +1     
  Lines         12355    12386      +31     
  Branches       1580     1588       +8     
============================================
+ Hits           9621     9655      +34     
+ Misses         2018     2011       -7     
- Partials        716      720       +4     
Files Changed Coverage Δ
...rye/reactive/messaging/kafka/impl/KafkaSource.java 86.87% <77.77%> (+0.55%) ⬆️
...fka/fault/KafkaDeadLetterSerializationHandler.java 84.61% <84.61%> (ø)
...messaging/kafka/DeserializationFailureHandler.java 80.00% <100.00%> (+13.33%) ⬆️
...ive/messaging/kafka/fault/DeserializerWrapper.java 70.00% <100.00%> (+0.76%) ⬆️
...ve/messaging/kafka/fault/KafkaDeadLetterQueue.java 85.50% <100.00%> (+0.43%) ⬆️
.../messaging/kafka/fault/KafkaDelayedRetryTopic.java 85.25% <100.00%> (-1.11%) ⬇️

... and 10 files with indirect coverage changes

@vsevel
Copy link

vsevel commented Aug 9, 2023

oh yes ;-) wonderful. thanks for the heads up.

@cescoffier cescoffier added this to the 4.10.0 milestone Aug 17, 2023
@cescoffier cescoffier merged commit 244d4d9 into smallrye:main Aug 17, 2023
3 checks passed
@vsevel
Copy link

vsevel commented Sep 17, 2023

hello. out of curiosity, what is your timeframe for 4.10 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants