Improvements to post-processing ack management #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or methods Closes smallrye#2732 and smallrye#2733
ozangunalp
force-pushed
the
ack_management
branch
3 times, most recently
from
1d871c6
to
728c022
Compare
ozangunalp
force-pushed
the
ack_management
branch
from
728c022
to
92fa8f8
Compare
cescoffier
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to closing #2732 and #2733 we introduce post-processsing acknowledgement support for the following signatures :
@Outgoing @Incoming Message<O> method(I payload)@Outgoing @Incoming CompletionStage<Message<O>> method(I payload)@Outgoing @Incoming Uni<Message<O>> method(I payload)@Outgoing @Incoming Message<O> method(Message<I> payload)For the last one, if acknowledgments are already handled in the method, there will be duplicate (n)acks.