Add initial timeout property for KafkaRequestReply when using latest offset
#2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Malandril Thank you for this clean PR! I'd like to push a change to disable the wait when Here is the proposition : 4940198 |
Yeah it would be great ! Thanks! |
ozangunalp
approved these changes
Sep 23, 2024
cescoffier
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alleviates some a part of the issue of #2714 notably the fact that at start the
KafkaRequestReplyuses the same timeout to wait for assignments and to await replies when using thelatestoffset.I didn't have any idea just named the property
reply.initial-assignment-timeoutyou can propose a more suitable one if you think of one.