Merge pull request #324 from smalot/fix/font-elementmissing

Fix error when Font aren't available
smalot · Aug 31, 2020 · 5faf073 · 5faf073
2 parents 2abf9c8 + cc4c77f
commit 5faf073
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 0 deletions.
diff --git a/src/Smalot/PdfParser/Page.php b/src/Smalot/PdfParser/Page.php
@@ -64,6 +64,10 @@ public function getFonts()
         $resources = $this->get('Resources');
 
         if (method_exists($resources, 'has') && $resources->has('Font')) {
+            if ($resources->get('Font') instanceof ElementMissing) {
+                return [];
+            }
+
             if ($resources->get('Font') instanceof Header) {
                 $fonts = $resources->get('Font')->getElements();
             } else {

diff --git a/tests/Integration/PageTest.php b/tests/Integration/PageTest.php
@@ -32,7 +32,10 @@
 
 namespace Tests\Smalot\PdfParser\Integration;
 
+use Smalot\PdfParser\Document;
+use Smalot\PdfParser\Element\ElementMissing;
 use Smalot\PdfParser\Font;
+use Smalot\PdfParser\Page;
 use Tests\Smalot\PdfParser\TestCase;
 
 class PageTest extends TestCase
@@ -71,6 +74,35 @@ public function testGetFonts()
         $this->assertEquals(0, \count($fonts));
     }
 
+    public function testGetFontsElementMissing()
+    {
+        $headerResources = $this->getMockBuilder('Smalot\PdfParser\Header')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $headerResources->expects($this->once())
+            ->method('has')
+            ->willReturn(true);
+
+        $headerResources->expects($this->once())
+            ->method('get')
+            ->willReturn(new ElementMissing());
+
+        $header = $this->getMockBuilder('Smalot\PdfParser\Header')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $header->expects($this->once())
+            ->method('get')
+            ->willReturn($headerResources);
+
+        $page = new Page(new Document(), $header);
+        $fonts = $page->getFonts();
+
+        $this->assertEmpty($fonts);
+        $this->assertEquals([], $fonts);
+    }
+
     public function testGetFont()
     {
         // Document with text.