Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added alternative to composer autoloader #388

Merged
merged 9 commits into from
Feb 12, 2021
Merged

Conversation

k00ni
Copy link
Collaborator

@k00ni k00ni commented Feb 9, 2021

This PR provides a new file which acts as an alternative autoloader to Composer. It should make manual work obsolete in case Composer is not available. I named the autoloader file alt_autoload.php-dist so people can rename it to e.g. alt_autoload.php and adapt it as they see fit. This way they can make adaptions without to worry to override them on an update. Also extended README.md with a basic installation section.

Also added a basic test which checks if this works.

Fixes #117

I would love to hear feedback on this, especially from people who don't use Composer. If this PR is being accepted, we may close #117 and add a reference to the README.md.

CC @apmuthu

@k00ni k00ni requested a review from j0k3r February 9, 2021 10:28
@k00ni k00ni self-assigned this Feb 9, 2021
k00ni and others added 5 commits February 9, 2021 11:31
this is weird, because it works on my local machine
which also runs PHP 7.4
Running it together with Composer made no sense.
Copy link
Collaborator

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@ndmax
Copy link

ndmax commented Feb 10, 2021

Non-Composer-plain-old-manual-include user here... looks good to me. :-) Go for it!

@k00ni
Copy link
Collaborator Author

k00ni commented Feb 12, 2021

Thank you for the feedback. If problems related to this PR occur, please open a new issue.

@k00ni k00ni merged commit 73204b4 into master Feb 12, 2021
@k00ni k00ni deleted the pr/provide-alt-autoloader branch February 12, 2021 09:04
@WillRun4Cake
Copy link

I pulled the latest master branch, which included this merge, and tested it on my local machine using the non-Composer (alt_autoload.php-dist) method. It worked great! Thank you @k00ni for your effort on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using PdfParser without Composer
4 participants