INCODE data models update - second round of validation #146
+4,033
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
feki-rihab
commented
Jul 29, 2024
feki-rihab
commented
- Added the missing "id" & "type" in the examples.json files
- corrected the "$id" in the schema.json
- Adjusted the versions of the data models in the schema.json
- Renamed the data models file names with "Capital" letters
- Other minor fixes
examples lower case - deleted png files - added some missing examples
modified version
|
AS far as I see the comments were not completely addressed. please complete the review comments in this PR |
albertoabellagarcia
requested changes
Nov 27, 2024
| @@ -0,0 +1,10 @@ | |||
| description: This is a compilation list of the current adopters of the data model SenseHat of the Subject dataModel.Device. All fields are non mandatory. More info at https://smart-data-models.github.io/data-models/templates/dataModel/CURRENT_ADOPTERS.yaml | |||
There was a problem hiding this comment.
remove the sentence after All fields ...
There was a problem hiding this comment.
Do you mean to delete this sentence?
More info at https://smart-data-models.github.io/data-models/templates/dataModel/CURRENT_ADOPTERS.yaml
I still see it in the official data models tho. Please correct me if I am wrong.
P2CODE/AA1/Telematics/ADOPTERS.yaml
Outdated
| @@ -0,0 +1,10 @@ | |||
| description: This is a compilation list of the current adopters of the data model Telematic of the Subject dataModel.Aeronautics. All fields are non mandatory. More info at https://smart-data-models.github.io/data-models/templates/dataModel/CURRENT_ADOPTERS.yaml | |||
There was a problem hiding this comment.
same as previous adopters.yaml
|
please check that all files are present in all cases,. I.e. in this directory one of the examples is missing |
|
Hi Alberto,
Which is examples do you find missing?
…On Wed, Jan 29, 2025 at 2:46 PM Alberto Abella ***@***.***> wrote:
please check that all files are present in all cases,. I.e. in this
directory one of the examples is missing
https://github.com/smart-data-models/incubated/tree/2f18b7ed83a36fcee55cd9bcad247b8c3c74d818/P2CODE/AA1/SenseHat/examples
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCKXA6K3ATZ4UW3OQGFIUE32NDLTVAVCNFSM6AAAAABLTXQRISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRRGY4TKNJRGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Rihab Feki
Senior Data Engineer
M. +49 1573 4871599
***@***.***
www.fiware.org
<https://www.fiware.org/events>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.