feat!: reorganize CLI commands #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"info" is no more - it's been split up and moved. - Default "info" output has been moved to the default "chart-review" mode without any subcommand. - "info --ids" has been moved to a toplevel "ids" subcommand. - "info --labels" has been moved to a toplevel "labels" subcommand.
dogversioning
approved these changes
Jun 24, 2024
Comment on lines
+8
to
+10
| def make_subparser(parser: argparse.ArgumentParser) -> None: | ||
| cli_utils.add_project_args(parser) | ||
| parser.set_defaults(func=print_ids) |
There was a problem hiding this comment.
re" this and labels, maybe not now, but as you add in some of the other commands, should this move to a centralized location/base class?
There was a problem hiding this comment.
My plan was to let each command own its own specific logic, but provide all the shared code via cli_utils.py or other places.
Like you see above with cli_utils.add_project_args, but more of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"info" is no more - it's been split up and moved.
No functional changes here (except maybe some better help output in the "no config file found" case and the reminder about
--helpin the default output).This is part 1 of 4. Next will be the addition of a
--cvsoption to most commands. And part 3-4 will be some new commands (mentions & frequency).Checklist
docs/) needs to be updated