Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to supply user-defined state key. #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the ability to supply user-defined state key. #168

wants to merge 1 commit into from
+25 −4

Commits on Apr 7, 2023

  1. Add the ability to supply user-defined state key. 

    Current Node examples of storing user session with a custom storage implementation include generating a unique ID, and distinguishing between user states with this unique ID. This ID is not related to the state key that is generated by the fhirclient library.

In this Pull Request, I am proposing a change where the user of this library can supply their own state key, and this could ostensibly be the same unique identifier that's used for distinguishing users in whatever custom storage solution is implemented. The benefit to this approach is that the state key is already being passed along in the redirect, so one does not have to set cookies in order to recall which user is which. This seems to be more in line with how the state parameter was intended to be used in the OAuth flow.
    @ben-storyhealth
    ben-storyhealth committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    33ae488 View commit details
    Browse the repository at this point in the history