WIP: don't simply toss extensions #347
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
force-pushed
the
mikix/extensions
branch
from
962aa53
to
3708ce2
Compare
- Print a report at the end of the ETL run of all extensions stripped by resource, URL, and count. - Plus a report on resources skipped due to unrecognized modifier extensions. - Leave stub extension in place, with just the `url` field, so that we can inspect stripped extensions in SQL if we want. Allow the following new extensions: - http://hl7.org/fhir/StructureDefinition/data-absent-reason - http://hl7.org/fhir/StructureDefinition/derivation-reference - http://hl7.org/fhir/StructureDefinition/event-performerFunction - http://hl7.org/fhir/us/core/StructureDefinition/us-core-jurisdiction - http://hl7.org/fhir/us/core/StructureDefinition/us-core-medication- adherence - http://hl7.org/fhir/us/core/StructureDefinition/us-core-sex - http://hl7.org/fhir/us/core/StructureDefinition/us-core-tribal- affiliation - https://fhir-ehr.cerner.com/r4/StructureDefinition/client- organization - https://fhir-ehr.cerner.com/r4/StructureDefinition/precision Ignore the following extensions: - http://hl7.org/fhir/us/core/StructureDefinition/us-core-direct - https://fhir-ehr.cerner.com/r4/StructureDefinition/estimated- financial-responsibility-amount Drop support for the following extension: - http://hl7.org/fhir/us/core/StructureDefinition/us-core-sex-for- clinical-use (this was in US Core 6.0 ballot, but didn't make final cut - it seems to be replaced by just 'us-core-sex')
mikix
force-pushed
the
mikix/extensions
branch
from
3708ce2
to
20d7243
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extremely not ready - just dropping this here as a step forward when I pick this up again.
TODO: it doesn't seem fully wise to simply erase the contents of an extension - maybe we should mark that we redacted it, for the future. There's a Meta.security way of doing that (which we normally strip out of resources) or... throw a valueString of "cumulus wuz here" in there... needs a think.
Fixes #346
Checklist
docs/) needs to be updated