-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't simply toss extensions #347
Conversation
1af1fc4
to
cb36c6f
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
cb36c6f
to
c749175
Compare
- Print a report at the end of the ETL run of all extensions stripped by resource, URL, and count. - Plus a report on resources skipped due to unrecognized modifier extensions. - Leave stub extension in place, with just the `url` field, so that we can inspect stripped extensions in SQL if we want. This commit allows a bunch of extensions in use today. Scanned some sample data from Cerner and Epic to find common extensions. We'll surely add to the list going forward, to avoid annoying folks with the unknown-extension warning. Ignore the following extensions: - http://hl7.org/fhir/StructureDefinition/iso21090-TEL-address - http://hl7.org/fhir/StructureDefinition/rendered-value - http://hl7.org/fhir/us/core/StructureDefinition/us-core-direct - https://fhir-ehr.cerner.com/r4/StructureDefinition/clinical- instruction - https://fhir-ehr.cerner.com/r4/StructureDefinition/estimated- financial-responsibility-amount - http://open.epic.com/FHIR/StructureDefinition/extension/birth- location Drop support for the following extension: - http://hl7.org/fhir/us/core/StructureDefinition/us-core-sex-for- clinical-use (this was in US Core 6.0 ballot, but didn't make final cut - it seems to be replaced by just 'us-core-sex')
c749175
to
820acfc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that there's some refactoring noise - I basically tweaked how the recursive scrubbing worked - basically just reduced the amount of full-object access each scrubber method had.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These test files are for the ms-tool tests, which now no longer strips the extensions - so these changes just add the input extensions to the expected output.
url
field, so that we can inspect stripped extensions in SQL if we want.This commit allows a bunch of extensions in use today. Scanned some sample data from Cerner and Epic to find common extensions. We'll surely add to the list going forward, to avoid annoying folks with the unknown-extension warning.
Ignore the following extensions:
Drop support for the following extension:
Fixes #346
Example output
Checklist
docs/
) needs to be updated