Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a new NLP explainer #278

Merged
merged 1 commit into from
Oct 9, 2023
Merged

docs: add a new NLP explainer #278

merged 1 commit into from
Oct 9, 2023

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Oct 6, 2023

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

@@ -1,89 +0,0 @@
---
# This belongs in the global docs. Until then, keep it in repo but excluded.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now properly lives in the global docs -- drop it here

Copy link
Contributor

@dogversioning dogversioning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly, a very nice doc overall

@mikix
Copy link
Contributor Author

mikix commented Oct 9, 2023

I also made some minor import tweaks to avoid a new pylint error about circular imports.

@mikix mikix merged commit 5e69a53 into main Oct 9, 2023
2 checks passed
@mikix mikix deleted the mikix/nlp-docs branch October 9, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants