bulk: store "deleted" and "error" results in export subfolders #343
+126
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
force-pushed
the
mikix/bulk-deleted
branch
from
2ac3508 to
721c398
Compare
dogversioning
approved these changes
Aug 29, 2024
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
If the bulk export server provides an array of error messages or an array of deleted resources, make sure we persist those on disk. Previously, we only printed the error messages to the console. We still do that, but also write them to an error/ subfolder. Previously, we ignored any deleted resources. Now we write them to a deleted/ subfolder. This matches the behavior of bulk-data-client.
mikix
force-pushed
the
mikix/bulk-deleted
branch
from
721c398 to
eb488f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bulk export server provides an array of error messages or an array of deleted resources, make sure we persist those on disk.
Previously, we only printed the error messages to the console. We still do that, but also write them to an error/ subfolder.
Previously, we ignored any deleted resources.
Now we write them to a deleted/ subfolder.
This matches the behavior of bulk-data-client.
This is part 1 of #167.
Next step is actually processing a
deleted/folder in any input ndjson.Checklist
docs/) needs to be updated