Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple bulk logging improvements #350

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Oct 17, 2024

  • Add some debugging information about client version to the logs
  • Parse oddly interweaved logs we come across (where there are multiple export events being written at same time - shouldn't happen, but we now correctly only grab one thread out)

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

Copy link

github-actions bot commented Oct 17, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3465 3404 98% 98% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cumulus_etl/loaders/fhir/export_log.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 484de03 by action🐍

- Add some debugging information about client version to the logs
- Parse oddly interweaved logs we come across (where there are multiple
  export events being written at same time - shouldn't happen, but we
  now correctly only grab one thread out)
@mikix mikix force-pushed the mikix/logging-improvements branch from f7bf901 to 484de03 Compare October 17, 2024 15:29
@mikix mikix marked this pull request as ready for review October 17, 2024 15:30
@mikix mikix merged commit 3256616 into main Oct 17, 2024
3 checks passed
@mikix mikix deleted the mikix/logging-improvements branch October 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants