Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new init subcommand #352

Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat: add new init subcommand #352

merged 1 commit into from
Oct 23, 2024

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Oct 23, 2024

This will create an empty table for each basic resource that we support. This is a convenience command to get up and running faster or to refresh your database schemas in case we change them in the future.

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

Copy link

github-actions bot commented Oct 23, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3506 3445 98% 98% 🟢

New Files

File Coverage Status
cumulus_etl/etl/init/init.py 100% 🟢
cumulus_etl/etl/init/cli.py 100% 🟢
TOTAL 100% 🟢

Modified Files

File Coverage Status
cumulus_etl/init.py 100% 🟢
cumulus_etl/cli.py 100% 🟢
cumulus_etl/cli_utils.py 100% 🟢
cumulus_etl/etl/cli.py 100% 🟢
TOTAL 100% 🟢

updated for commit: eb1153f by action🐍

@mikix mikix force-pushed the mikix/init-command branch from cac9dad to 34317f9 Compare October 23, 2024 17:00
@mikix mikix marked this pull request as ready for review October 23, 2024 17:17

with cli_utils.make_progress_bar() as progress:
# Set up progress bar
total_steps = len(list(get_task_tables())) + 1 # extra one is format init
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - can you reword this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra 1 is initializing the formatter

This will create an empty table for each basic resource that we
support. This is a convenience command to get up and running faster
or to refresh your database schemas in case we change them in the
future.
@mikix mikix force-pushed the mikix/init-command branch from 34317f9 to eb1153f Compare October 23, 2024 17:55
@mikix mikix merged commit ceb9ce7 into main Oct 23, 2024
3 checks passed
@mikix mikix deleted the mikix/init-command branch October 23, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants