Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deid): keep some fields from DiagnosticReport.presentedForm #365

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

mikix
Copy link
Contributor

@mikix mikix commented Nov 20, 2024

Specifically, treat it the same as we treat DocumentReference.content.

  • Strip data & url into _data & _url data-absent-reason extensions.
  • But keep all the interesting metadata like contentType and language.
  • Add Binary scope when requesting DiagnosticReport scopes.

Checklist

  • Consider if documentation (like in docs/) needs to be updated
  • Consider if tests should be added

@mikix mikix marked this pull request as ready for review November 20, 2024 16:57
Copy link

github-actions bot commented Nov 20, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3610 3549 98% 98% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cumulus_etl/deid/scrubber.py 100% 🟢
cumulus_etl/fhir/fhir_client.py 100% 🟢
TOTAL 100% 🟢

updated for commit: a850050 by action🐍

@mikix mikix force-pushed the mikix/diagreport-attachments branch from 68084dc to 93dd169 Compare November 20, 2024 19:21
Specifically, treat it the same as we treat DocumentReference.content.
- Strip data & url into _data & _url data-absent-reason extensions.
- But keep all the interesting metadata like contentType and language.
- Add Binary scope when requesting DiagnosticReport scopes.
@mikix mikix force-pushed the mikix/diagreport-attachments branch from 93dd169 to a850050 Compare November 20, 2024 19:22
@mikix mikix merged commit 24be40b into main Nov 21, 2024
3 checks passed
@mikix mikix deleted the mikix/diagreport-attachments branch November 21, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants