UMLS table creation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
force-pushed
the
mg/umls-setup
branch
from
0cdac0a
to
8d36baa
Compare
dogversioning
commented
May 8, 2024
| ruff check | ||
| ruff format --check | ||
|
|
||
| unittest: |
There was a problem hiding this comment.
This is expected to fail until we cut a 2.1 release.
Comment on lines
+12
to
+17
| - repo: https://github.com/sqlfluff/sqlfluff | ||
| rev: 2.3.4 | ||
| hooks: | ||
| - id: sqlfluff-lint | ||
| types: [] | ||
| types_or: [sql,jinja] |
There was a problem hiding this comment.
not used currently, but it's possible there will be jinja files in here in the future.
mikix
approved these changes
May 8, 2024
|
|
||
| :param root: the location at the base of the path you want to remove | ||
|
|
||
| TODO: replace with native pathlib.rmtree when upgrading to python 3.12 |
There was a problem hiding this comment.
Does that method actually exist? I don't see it in the docs
You could/should replace this with shutil.rmtree today.
There was a problem hiding this comment.
walk() is the function i was looking for.
I was trying to keep all library path operation in pathlib - this might be silly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the initial UMLS creation study.