Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casing issue w/ pyproject.toml #3

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

dogversioning
Copy link
Contributor

  • changes README.MD to README.md to match pyproject format/best practices
  • explicit versioning in pyproject.toml instead of dynamic

@@ -1,4 +1,5 @@
[project]
version = "0.1.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You like it here rather than __init__.py?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not 1.0? 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i went back and forth - for studies, idk? they don't change as fast, but you could talk me out of it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh I don't know what you're thinking about the speed of changes.

I think the benefit of the version living in __init__.py is that it can be programmatically retrieved. If it isn't dynamic and just hardcoded in the pyproject.toml file, the version is only packaging metadata and not also a matter of inspectable code. (which is a bit of a lie, since there are ways to ask python to go look up the version of a module if it's been installed correctly - but that's still an if)

@dogversioning dogversioning merged commit 395d732 into main May 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants