fix: disable files that are unnecessary to scan #1241
Conversation
| @@ -32,13 +34,22 @@ exclude_paths: | |||
| - node_modules/ | |||
| - scripts/ | |||
| - src/config/ | |||
| - __tests__/ | |||
There was a problem hiding this comment.
maybe the tests are ok, but only the snapshots inside not?
There was a problem hiding this comment.
I think this covers the whole tests folder. Am I wrong?
There was a problem hiding this comment.
yes, this is what i ask about. why should all be excluded? i suggest excluding just snapshots
There was a problem hiding this comment.
Hmm. Okay, I understand better now. Inside the tests folder we have the snapshots folder. But there are also snapshots folders inside the screens or navigation folders. Do you think we should block all snapshots folders? Why don't you want to block all tests folders? We haven't written a new test for a very long time and I don't think this section needs to be checked.
There was a problem hiding this comment.
the fact that we don't write tests shouldn't be a reason for codeclimate not to take this into account. we should write tests and if we do, the files should be checked, right?! it's not codeclimate's fault that we neglect this.
if the snapshot folder does not make any problems for codeclimate, you do not need to exclude it. i don't know, find some articles or other repositories to check out how to do best.
ardasnturk
force-pushed
the
fix/SVA-1557-disable-files-that-are-unnecessary-to-scan
branch
from
16e8b64 to
35090ab
Compare
- added file types we don't want codeclimate to scan to `exclude_paths` - added .ts and .tsx file types that we want to be rated by codeclimate to the `ratings` section SVA-1557
ardasnturk
force-pushed
the
fix/SVA-1557-disable-files-that-are-unnecessary-to-scan
branch
from
35090ab to
16b1c08
Compare
donni106
force-pushed
the
master
branch
3 times, most recently
from
67ae56a to
30b5bc4
Compare
exclude_pathsratingssectionSVA-1557