Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved External Public Directory related issues #14

Closed
wants to merge 23 commits into from

Conversation

DhruviChotai
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix
  • Optimization

Description

Manage External Storage was not returning true even after the permission was granted. Changed it to isExternalStorage perm, and also available for 13 and 14.

Instructions, Screenshots, Recordings

Not as of now

Checks

  • SonarLint
  • Locally Tested

@amitsid1408 amitsid1408 changed the base branch from main to development May 13, 2024 07:50
Copy link
Collaborator

@amitsid1408 amitsid1408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amitsid1408
Copy link
Collaborator

Resolve conflict and let me know once we're good to go. @harshilpadsala88 @DhruviChotai

@amitsid1408
Copy link
Collaborator

Closing this PR as this is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants