Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRIB-562: setting up go before running CRIB to ensure GOBIN is properly set #726

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rafaelfelix
Copy link
Contributor

@rafaelfelix rafaelfelix commented Nov 26, 2024

this should fix the issue related to the crib executable not being found in PATH, as well as caching dependencies

had to be derived from tag [email protected] in order to fix smartcontractkit/chainlink#15399 prior to moving it to GAP v2 (currently undergoing). THIS IS A SHORT TERM FIX, NOT MEANT TO BE MERGED OR DELETED.

tagged manually as [email protected]

UPDATE: commit d4d9ce3fad044642d8d2f7ae5aca9f8c78b0073a in this branch tagged as [email protected]

@rafaelfelix rafaelfelix added the bug Something isn't working label Nov 27, 2024
rafaelfelix added a commit that referenced this pull request Nov 27, 2024
see PR description for context
rafaelfelix added a commit to smartcontractkit/chainlink that referenced this pull request Nov 27, 2024
…he GOBIN fix

the latest had issues which will be addressed in a separate GAP v2 upgrade initiative.
in the meantime, this is meant to fix the issue on the short term.

see: smartcontractkit/.github#726
@rafaelfelix rafaelfelix marked this pull request as ready for review November 27, 2024 08:22
@rafaelfelix rafaelfelix requested a review from a team as a code owner November 27, 2024 08:22
rafaelfelix added a commit to smartcontractkit/chainlink that referenced this pull request Nov 27, 2024
…he GOBIN fix

the latest had issues which will be addressed in a separate GAP v2 upgrade initiative.
in the meantime, this is meant to fix the issue on the short term.

see: smartcontractkit/.github#726
github-merge-queue bot pushed a commit to smartcontractkit/chainlink that referenced this pull request Nov 27, 2024
* bump crib-deploy-environment version

* modifying inputs for deploy-crib due to GAP v2 upgrade

following smartcontractkit/crib@109a8df#diff-cd4cd267fd322151fee5bee287c420a984a696b639c2949903ad232cf74efbadR82

* using crib-deploy-environment version devired from 2.1.0 containing the GOBIN fix

the latest had issues which will be addressed in a separate GAP v2 upgrade initiative.
in the meantime, this is meant to fix the issue on the short term.

see: smartcontractkit/.github#726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working do not merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants