-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRIB-562: setting up go before running CRIB to ensure GOBIN is properly set #726
Open
rafaelfelix
wants to merge
2
commits into
main
Choose a base branch
from
CRIB-562/gobin-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainchad
reviewed
Nov 26, 2024
rafaelfelix
force-pushed
the
CRIB-562/gobin-fix
branch
from
November 27, 2024 08:04
189034e
to
c1c5e09
Compare
rafaelfelix
added a commit
that referenced
this pull request
Nov 27, 2024
see PR description for context
rafaelfelix
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Nov 27, 2024
…he GOBIN fix the latest had issues which will be addressed in a separate GAP v2 upgrade initiative. in the meantime, this is meant to fix the issue on the short term. see: smartcontractkit/.github#726
rafaelfelix
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Nov 27, 2024
…he GOBIN fix the latest had issues which will be addressed in a separate GAP v2 upgrade initiative. in the meantime, this is meant to fix the issue on the short term. see: smartcontractkit/.github#726
github-merge-queue bot
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Nov 27, 2024
* bump crib-deploy-environment version * modifying inputs for deploy-crib due to GAP v2 upgrade following smartcontractkit/crib@109a8df#diff-cd4cd267fd322151fee5bee287c420a984a696b639c2949903ad232cf74efbadR82 * using crib-deploy-environment version devired from 2.1.0 containing the GOBIN fix the latest had issues which will be addressed in a separate GAP v2 upgrade initiative. in the meantime, this is meant to fix the issue on the short term. see: smartcontractkit/.github#726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should fix the issue related to the crib executable not being found in PATH, as well as caching dependencies
had to be derived from tag
[email protected]
in order to fix smartcontractkit/chainlink#15399 prior to moving it to GAP v2 (currently undergoing). THIS IS A SHORT TERM FIX, NOT MEANT TO BE MERGED OR DELETED.tagged manually as
[email protected]
UPDATE: commit
d4d9ce3fad044642d8d2f7ae5aca9f8c78b0073a
in this branch tagged as[email protected]