Feat/support decimals for Hedera #25
Open
+4,588
−2,553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in the integration test, swap out bridge token ABI for one that includes drip() functionality. - add integration tests for Hedera->Sepolia. Failing as expected on Token Transfer due to InsufficientFeeTokenAmount() error. - update package.json test script.
Currently only Hedera (https://docs.chain.link/ccip/concepts/best-practices/evm#hedera-fee-decimal-handling). Integration tests added. Tidy ups on TODOs required.
Update imports. Update CCIPSend text message integration tests to use pre-deployed simple receiver contract. (note: Tests only successful TX on send. Due to finality latency does not test destination side).
…nents. This is to avoid breakages as wagmi updates in ccip-js are causing breaks in react-components
HelloKashif
approved these changes
Jun 23, 2025
Update Contributing guidelines in README.
…in react-components package.json and replace with ccip-js v ^0.2.4.
This is because it updates from 2.12.7 --> 2.15.6 which causes breaking changes in viem. There is a type mismatch that gets caused, even though they're minor versions and ought not cause breaking changes. Note that currently 1. viem is pinned to only 1 fixed version 2. same now for wagmi 3. react-components package depends on ccip-js and since it has carat it will update on install to next patch.
pnpm workspace linking so that local changes in ccip-js are available to the react-components package when building and during CI/CD even if those changes are unpublished to npm. --> replaced "@chainlink/ccip-js": "^0.2.4" with "@chainlink/ccip-js": "workspace:^": When publishing pnpm automatically converts the "workspace:^" back to a regular semver range based on the actual version of the workspace package.
zeuslawyer
force-pushed
the
feat/support-decimals
branch
from
61fe913 to
97e7ace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccip-jsto v0.2.5ccip-react-componentsto v0.3.1 as its wagmi dependency is now hard-pinned to avoid the issue of updating from 2.12.x --> 2.15.x ( see commit sha c7a72f5)Testing CCIP-JS package from this branch
Link, test the package from this branch locally then unlink.
1. Link The CCIP Package Globally On Your Dev Machine
Open a terminal and navigate to package
Create a global symlink:
This Registers ccip-js local folder as a “linked” package by its package name @chainlink/ccip-js.
2. Link It into Your Client Project
In a new terminal, go to your client project:
cd /path/to/your-clientLink against your local package:
Creates a symlink in global
node_modules/pointing to your local code.3. Develop & Test
Import or require the package in the demo as normal
4. Clean Up
In your client project, remove the link:
cd /path/to/your-client npm unlink @chainlink/ccip-js(Optional) In your package folder, remove the global link:
cd /../../ccip-all/ccip-javascript-sdk/packages/ccip-js npm unlink