Addressed PR comments

smartcontractkit · Jul 10, 2024 · ebbbc28 · ebbbc28
1 parent 717db27
commit ebbbc28
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 8 deletions.
diff --git a/core/chains/evm/config/toml/defaults/Celo_Mainnet.toml b/core/chains/evm/config/toml/defaults/Celo_Mainnet.toml
@@ -1,5 +1,6 @@
 ChainID = '42220'
 ChainType = 'celo'
+FinalityDepth = 10
 FinalityTagEnabled = true
 LogPollInterval = '5s'
 MinIncomingConfirmations = 1

diff --git a/core/chains/evm/config/toml/defaults/Celo_Testnet.toml b/core/chains/evm/config/toml/defaults/Celo_Testnet.toml
@@ -1,5 +1,6 @@
 ChainID = '44787'
 ChainType = 'celo'
+FinalityDepth = 10
 FinalityTagEnabled = true
 LogPollInterval = '5s'
 MinIncomingConfirmations = 1

diff --git a/core/chains/evm/config/toml/defaults/Kroma_Mainnet.toml b/core/chains/evm/config/toml/defaults/Kroma_Mainnet.toml
@@ -1,5 +1,6 @@
 ChainID = '255'
 ChainType = 'kroma' # Kroma is based on the Optimism Bedrock architechture
+FinalityDepth = 700
 FinalityTagEnabled = true
 LogPollInterval = '2s'
 NoNewHeadsThreshold = '40s'

diff --git a/core/chains/evm/config/toml/defaults/Kroma_Sepolia.toml b/core/chains/evm/config/toml/defaults/Kroma_Sepolia.toml
@@ -1,5 +1,6 @@
 ChainID = '2358'
 ChainType = 'kroma' # Kroma is based on the Optimism Bedrock architechture
+FinalityDepth = 700
 FinalityTagEnabled = true
 LogPollInterval = '2s'
 NoNewHeadsThreshold = '40s'

diff --git a/core/chains/evm/config/toml/defaults/Metis_Mainnet.toml b/core/chains/evm/config/toml/defaults/Metis_Mainnet.toml
@@ -2,6 +2,7 @@
 ChainID = '1088'
 ChainType = 'metis'
 # Sequencer offers absolute finality
+FinalityDepth = 10
 FinalityTagEnabled = true
 MinIncomingConfirmations = 1
 NoNewHeadsThreshold = '0'

diff --git a/core/chains/evm/config/toml/defaults/Metis_Sepolia.toml b/core/chains/evm/config/toml/defaults/Metis_Sepolia.toml
@@ -1,5 +1,6 @@
 ChainID = '59902'
 ChainType = 'metis'
+FinalityDepth = 1
 FinalityTagEnabled = true
 MinIncomingConfirmations = 1
 NoNewHeadsThreshold = '0'

diff --git a/core/chains/evm/config/toml/defaults/zkSync_Sepolia.toml b/core/chains/evm/config/toml/defaults/zkSync_Sepolia.toml
@@ -1,6 +1,6 @@
 ChainID = '300'
 ChainType = 'zksync'
-FinalityDepth = 2400
+FinalityDepth = 200
 LogPollInterval = '5s'
 MinIncomingConfirmations = 1
 NoNewHeadsThreshold = '1m'

diff --git a/docs/CONFIG.md b/docs/CONFIG.md
@@ -3391,7 +3391,7 @@ AutoCreateKey = true
 BlockBackfillDepth = 10
 BlockBackfillSkip = false
 ChainType = 'kroma'
-FinalityDepth = 50
+FinalityDepth = 700
 FinalityTagEnabled = true
 LogBackfillBatchSize = 1000
 LogPollInterval = '2s'
@@ -3571,7 +3571,7 @@ AutoCreateKey = true
 BlockBackfillDepth = 10
 BlockBackfillSkip = false
 ChainType = 'zksync'
-FinalityDepth = 2400
+FinalityDepth = 200
 FinalityTagEnabled = false
 LogBackfillBatchSize = 1000
 LogPollInterval = '5s'
@@ -4112,7 +4112,7 @@ AutoCreateKey = true
 BlockBackfillDepth = 10
 BlockBackfillSkip = false
 ChainType = 'metis'
-FinalityDepth = 50
+FinalityDepth = 10
 FinalityTagEnabled = true
 LogBackfillBatchSize = 1000
 LogPollInterval = '15s'
@@ -4651,7 +4651,7 @@ AutoCreateKey = true
 BlockBackfillDepth = 10
 BlockBackfillSkip = false
 ChainType = 'kroma'
-FinalityDepth = 50
+FinalityDepth = 700
 FinalityTagEnabled = true
 LogBackfillBatchSize = 1000
 LogPollInterval = '2s'
@@ -5463,7 +5463,7 @@ AutoCreateKey = true
 BlockBackfillDepth = 10
 BlockBackfillSkip = false
 ChainType = 'celo'
-FinalityDepth = 50
+FinalityDepth = 10
 FinalityTagEnabled = true
 LogBackfillBatchSize = 1000
 LogPollInterval = '5s'
@@ -5733,7 +5733,7 @@ AutoCreateKey = true
 BlockBackfillDepth = 10
 BlockBackfillSkip = false
 ChainType = 'celo'
-FinalityDepth = 50
+FinalityDepth = 10
 FinalityTagEnabled = true
 LogBackfillBatchSize = 1000
 LogPollInterval = '5s'
@@ -6090,7 +6090,7 @@ AutoCreateKey = true
 BlockBackfillDepth = 10
 BlockBackfillSkip = false
 ChainType = 'metis'
-FinalityDepth = 50
+FinalityDepth = 1
 FinalityTagEnabled = true
 LogBackfillBatchSize = 1000
 LogPollInterval = '15s'