CCIP Integration tests - wiring contracts [CCIP-2698] #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoliman92
force-pushed
the
integration_test/new_contracts
branch
from
d5bff91
to
30e2739
Compare
asoliman92
force-pushed
the
integration_test/new_contracts
branch
from
30e2739
to
8bca6d3
Compare
asoliman92
force-pushed
the
integration_test/new_contracts
branch
from
8bca6d3
to
058d971
Compare
asoliman92
force-pushed
the
integration_test/new_contracts
branch
from
0fd5d5e
to
69af04b
Compare
* Generating NonceManager * Add onRamp as an authorized caller to NonceManager
asoliman92
changed the title
asoliman92
changed the title
asoliman92
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
asoliman92
force-pushed
the
integration_test/new_contracts
branch
from
e037726
to
5761eb2
Compare
dimkouv
reviewed
Jul 11, 2024
| * Test fails if any wiring between contracts is not correct. | ||
| */ | ||
| func TestPingPong(t *testing.T) { | ||
| _, universes := createUniverses(t, 4) |
There was a problem hiding this comment.
I find the naming a bit odd (universe).
Maybe better something like:
createUniverses -> setupContracts
universes -> chainContracts
There was a problem hiding this comment.
IMO tying it to contracts can limit us. We can later add log pollers and other stuff. It also already has backend, owner that are not contracts.
core/services/ocr3/plugins/ccip_integration_tests/ping_pong_test.go
Outdated
Show resolved
Hide resolved
makramkd
reviewed
Jul 11, 2024
core/services/ocr3/plugins/ccip_integration_tests/ping_pong_test.go
Outdated
Show resolved
Hide resolved
elatoskinas
approved these changes
Jul 11, 2024
makramkd
reviewed
Jul 11, 2024
core/services/ocr3/plugins/ccip_integration_tests/ping_pong_test.go
Outdated
Show resolved
Hide resolved
core/services/ocr3/plugins/ccip_integration_tests/ping_pong_test.go
Outdated
Show resolved
Hide resolved
makramkd
approved these changes
Jul 11, 2024
asoliman92
added a commit
that referenced
this pull request
Jul 16, 2024
Setting up a basic test that have basic OCR3 Nodes. Each Node can access 3 EVM chains that are created and connected to each others. Check [PR](#1148) for more details on creating the chains and connecting them. As JobSpecs for CCIP are not ready. The main goal of this PR is to have the nodes and AddDon on capability registry for these nodes for each chain. Once JobSpec is ready we'll be able to test that the nodes picks up the changes and deploys the plugins, start sending, receiving,..etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first phase of setting up full integration tests for the new setup.
Test is setting up 3 chains (let's call them A, B, C), each chain deploys and starts 2 ping pong contracts for the other 2.
A ---deploy+start---> (pingPongB, pingPongC)
B ---deploy+start---> (pingPongA, pingPongC)
C ---deploy+start---> (pingPongA, pingPongB)
and then checks that each ping pong contract emitted
CCIPSendRequestedevent from the expected source to destination.Test fails if any wiring between contracts is not correct.
Main part of helpers that's important to check is the setupInitialConfigs function. This makes sure that all configs are in place to be able to start sending between contracts.
Note: This setup is missing token pools to simplify it a little bit. It will be added in future PR when we start testing sending tokens.
https://smartcontract-it.atlassian.net/browse/CCIP-2698