CCIP-2694 : lane specific load Frequency #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalverra
approved these changes
Jul 5, 2024
| totalDuration := duration.Duration() | ||
| repeatTimes := totalDuration.Seconds() / segmentDuration.Seconds() | ||
| return wasp.CombineAndRepeat(int(math.Round(repeatTimes)), segments) | ||
| } else { |
There was a problem hiding this comment.
Nit: don't need this else after the return
b-gopalswami
approved these changes
Jul 5, 2024
AnieeG
force-pushed
the
ccip-2694-lane-specific-load
branch
from
246431f
to
72d523a
Compare
AnieeG
force-pushed
the
ccip-2694-lane-specific-load
branch
from
162b5d4
to
4bab3b2
Compare
kalverra
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The load frequency is set as a global frequency for all lanes under test. We need to specify destination specific load frequency so that frequency for slow-destination network lanes can be set differently than frequency of fast-destination network lanes.
Solution