[CCIP-3376] Add component into CCIP price estimators to account for c… #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain specific logic for Mantle
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
matYang
reviewed
Sep 19, 2024
matYang
reviewed
Sep 19, 2024
core/services/ocr2/plugins/ccip/estimatorconfig/interceptors/mantle/interceptor.go
Outdated
Show resolved
Hide resolved
matYang
reviewed
Sep 19, 2024
core/services/ocr2/plugins/ccip/estimatorconfig/interceptors/mantle/interceptor.go
Outdated
Show resolved
Hide resolved
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
matYang
reviewed
Sep 20, 2024
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
matYang
reviewed
Sep 20, 2024
core/services/ocr2/plugins/ccip/estimatorconfig/interceptors/mantle/interceptor.go
Outdated
Show resolved
Hide resolved
core/services/ocr2/plugins/ccip/estimatorconfig/interceptors/mantle/interceptor.go
Outdated
Show resolved
Hide resolved
matYang
reviewed
Sep 20, 2024
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
matYang
reviewed
Sep 24, 2024
matYang
approved these changes
Sep 24, 2024
mateusz-sekara
requested changes
Sep 24, 2024
core/services/ocr2/plugins/ccip/estimatorconfig/interceptors/mantle/interceptor.go
Outdated
Show resolved
Hide resolved
| // ModifyGasPriceComponents returns modified gasPrice. | ||
| func (i *Interceptor) ModifyGasPriceComponents(ctx context.Context, execGasPrice, daGasPrice *big.Int) (*big.Int, *big.Int, error) { | ||
| if time.Since(i.tokenRatioLastUpdate) > tokenRatioUpdateInterval { | ||
| mantleTokenRatio, err := i.getMantleTokenRatio(ctx) |
There was a problem hiding this comment.
I guess we can't just call contracts directly from the plugin logic, can we @dimkouv . I think it should belong to some reader to stay compliant with loops
There was a problem hiding this comment.
Since this logic is hidden behind the custom provider interface it should still be compliant with loops.
core/services/ocr2/plugins/ccip/estimatorconfig/interceptors/mantle/interceptor.go
Show resolved
Hide resolved
core/services/ocr2/plugins/ccip/estimatorconfig/interceptors/mantle/interceptor.go
Show resolved
Hide resolved
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
mateusz-sekara
approved these changes
Sep 24, 2024
core/services/ocr2/plugins/ccip/estimatorconfig/interceptors/mantle/interceptor.go
Show resolved
Hide resolved
valerii-kabisov-cll
temporarily deployed
to
sdlc
GitHub Actions
Inactive
|
patrickhuie19
approved these changes
Sep 24, 2024
valerii-kabisov-cll
deleted the
CCIP-3376-custom-mantle-price-estimator
branch
valerii-kabisov-cll
added a commit
that referenced
this pull request
Oct 3, 2024
#1446) [https://smartcontract-it.atlassian.net/browse/CCIP-3376](https://smartcontract-it.atlassian.net/browse/CCIP-3376) The CCIP gas limit is set by customers. This cannot be changed because this limit is directly used within the contracts (which expect limits in terms of ETH). Also, the L2 gas price returned from our current estimators for Mantle is in MNT. Therefore, the final formula needed for CCIP to calculate L2 transaction fees is the following: gasLimit_EVM * (gasPrice_Mantle * TokenRatio) Therefore, we need to multiply the gas price returned from our gas estimators by tokenRatio for CCIP. This should happen in the CCIP price estimator. Currently, we have no component here for chain-specific logic, so we will need to add this functionality. --------- Co-authored-by: Matt Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CCIP-3376
The CCIP gas limit is set by customers. This cannot be changed because this limit is directly used within the contracts (which expect limits in terms of ETH). Also, the L2 gas price returned from our current estimators for Mantle is in MNT. Therefore, the final formula needed for CCIP to calculate L2 transaction fees is the following:
gasLimit_EVM * (gasPrice_Mantle * TokenRatio)
Therefore, we need to multiply the gas price returned from our gas estimators by tokenRatio for CCIP. This should happen in the CCIP price estimator. Currently, we have no component here for chain-specific logic, so we will need to add this functionality.