Add RMNHomeAddress in the OCR3Config #1449
Conversation
0xnogo
requested review from
makramkd,
elatoskinas,
RayXpub and
a team
as code owners
LCOV of commit
|
0xnogo
changed the title
0xnogo
force-pushed
the
ng/rmnhome-ocr3config
branch
from
b26f529
to
88b67d0
Compare
| @@ -600,6 +618,7 @@ contract CCIPConfig_ConfigStateMachine is CCIPConfigSetup { | |||
| CCIPConfigTypes.OCR3Config memory config = CCIPConfigTypes.OCR3Config({ | |||
| pluginType: Internal.OCRPluginType.Commit, | |||
| offrampAddress: abi.encodePacked(keccak256(abi.encode("offramp"))), | |||
There was a problem hiding this comment.
@makramkd why are we using encodePacked? That's almost always bad and in this case it's the same as abi.encode, right? Let's replace them all with normal abi.encode's
There was a problem hiding this comment.
Yeah, I used it in this case because encodePacked and encode give the same output. Its only used in tests, the contract only uses encode
There was a problem hiding this comment.
Replaced all the encodePacked with abi.encode
| @@ -647,6 +666,7 @@ contract CCIPConfig_ConfigStateMachine is CCIPConfigSetup { | |||
| cfgs[i] = CCIPConfigTypes.OCR3Config({ | |||
| pluginType: Internal.OCRPluginType.Commit, | |||
There was a problem hiding this comment.
Maybe not in scope for this PR but there's a very high amount of duplication going on here, we should fix
Can you do a quick replace all in this file?
There was a problem hiding this comment.
You mean a quick replace of the encodePacked right?
|
Adding
rmnHomeAddressin theOCR3Configstruct + generated wrappers.