CCIPConfig -> CCIPHome #1454
Closed
CCIPConfig -> CCIPHome #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename configCount to version remove ERC165 remove CCIPConfigTypes
LCOV of commit
|
makramkd
reviewed
Sep 20, 2024
| // Validate the state transition being proposed, which is implicitly defined by the combination | ||
| // of lengths of the current and new configurations. | ||
| _validateConfigStateTransition(currentState, newState); | ||
|
|
||
| uint64[] memory configCounts = new uint64[](newConfig.length); |
There was a problem hiding this comment.
Should we replace all occurrences of configCount with version?
makramkd
reviewed
Sep 20, 2024
| /// @notice Determine the config state of the configuration from the length of the config. | ||
| /// @param configLen The length of the configuration. | ||
| /// @return The config state. | ||
| function _stateFromConfigLength(uint256 configLen) internal pure returns (CCIPConfigTypes.ConfigState) { |
There was a problem hiding this comment.
Implicitly being done somewhere else or just inlined?
There was a problem hiding this comment.
Inlined into _computeNewConfigWithMeta
makramkd
reviewed
Sep 20, 2024
| if (newConfigWithMeta[0].configCount != 1) { | ||
| revert WrongConfigCount(newConfigWithMeta[0].configCount, 1); | ||
| if (newConfigWithMeta[0].version != 1) { | ||
| revert WrongConfigCount(newConfigWithMeta[0].version, 1); |
There was a problem hiding this comment.
Suggested change
| revert WrongConfigCount(newConfigWithMeta[0].version, 1); | |
| revert WrongVersion(newConfigWithMeta[0].version, 1); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename configCount to version
remove CCIPConfigTypes
rm _groupByPluginType
Steamline code
don't pass in derivable values