CRIB-359: ignoring problematic git tag breaking CRIB CCIP builds #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following error when building CCIP for CRIB: ``` build:app • parsing tag build:app ⨯ release failed after 0s error=failed to parse tag 'contracts-ccip/v1.5.0-beta.0' as semver: Invalid Semantic Version ``` Even though the best would be to ignore it based on the prefix `contracts-ccip`, that requires goreleaser-pro which is not currently available in the nix shell. We should add it in the long run, but this issue needs an immediate fix for now.
rafaelfelix
force-pushed
the
crib-ignore-contracts-ccip-tag-prefix
branch
from
f5a1ea5
to
cb46eaf
Compare
rafaelfelix
changed the title
andrevmatos
approved these changes
Sep 24, 2024
|
makramkd
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the following error when building CCIP for CRIB:
Solution
Even though the best would be to ignore it based on the prefix
contracts-ccip, that requires goreleaser-prowhich is not currently available in the nix shell. We should add it in the long run, but this issue needs an immediate fix for now.