Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pragma to most restrictive dependency or feature #1466

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Update pragma to most restrictive dependency or feature #1466

merged 3 commits into from
Sep 25, 2024

Conversation

RyanRHall
Copy link
Collaborator

Motivation

We have several contracts using ^0.8.0 but also custom errors, or a child contract with custom errors. We also have several contracts at ^0.8.0 but a dependency locked at 0.8.24.

Solution

Update all pragmas to the pragma of the most restrictive dep or the minimum to enable custom errors (0.8.4)

@RyanRHall RyanRHall mentioned this pull request Sep 24, 2024
Closed
@RyanRHall RyanRHall changed the title update pragma to most restrictive dependancy or feature needs in ccip… Update pragma to most restrictive dependency or feature Sep 24, 2024
@RyanRHall RyanRHall force-pushed the CCIP-3153-bump-solidity-version-of-contracts-using-custom-errors branch from 2af21b5 to a122fc9 Compare September 24, 2024 21:09
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

LCOV of commit 1f5db67 during Solidity Foundry #8367

Summary coverage rate:
  lines......: 97.7% (2284 of 2338 lines)
  functions..: 94.6% (421 of 445 functions)
  branches...: 93.6% (543 of 580 branches)

Files changed coverage rate: n/a

@RyanRHall RyanRHall enabled auto-merge (squash) September 25, 2024 00:18
@RyanRHall RyanRHall force-pushed the CCIP-3153-bump-solidity-version-of-contracts-using-custom-errors branch from 23a6554 to 1f5db67 Compare September 25, 2024 14:27
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@RyanRHall RyanRHall merged commit 390ee23 into ccip-develop Sep 25, 2024
127 checks passed
@RyanRHall RyanRHall deleted the CCIP-3153-bump-solidity-version-of-contracts-using-custom-errors branch September 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR approved these changes

@jhweintraub jhweintraub jhweintraub approved these changes

@0xsuryansh 0xsuryansh 0xsuryansh approved these changes

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RyanRHall @RensR @jhweintraub @0xsuryansh