Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccip home #1473

Merged
merged 9 commits into from
Sep 30, 2024
Merged

ccip home #1473

merged 9 commits into from
Sep 30, 2024

Conversation

RensR
Copy link
Collaborator

@RensR RensR commented Sep 27, 2024

Fresh PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 27, 2024 •
edited
Loading

LCOV of commit db86176 during Solidity Foundry #8440

Summary coverage rate:
  lines......: 97.8% (2263 of 2313 lines)
  functions..: 95.3% (426 of 447 functions)
  branches...: 93.6% (537 of 574 branches)

Files changed coverage rate: n/a

RensR
RensR commented Sep 30, 2024
View reviewed changes
contracts/scripts/native_solc_compile_all_ccip
@@ -73,8 +73,7 @@ compileContract ccip/RMN.sol
compileContract ccip/ARMProxy.sol
compileContract ccip/tokenAdminRegistry/TokenAdminRegistry.sol
compileContract ccip/tokenAdminRegistry/RegistryModuleOwnerCustom.sol
compileContract ccip/capability/CCIPConfig.sol
compileContract ccip/capability/interfaces/IOCR3ConfigEncoder.sol
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merged into ICCIPEncodingUtils

@RensR RensR marked this pull request as ready for review September 30, 2024 10:38
@RensR RensR requested review from elatoskinas, RayXpub and a team as code owners September 30, 2024 10:38
RensR
RensR commented Sep 30, 2024
View reviewed changes
contracts/src/v0.8/ccip/FeeQuoter.sol
uint32 destDataAvailabilityOverheadGas; // | Extra data availability gas charged on top of the message, e.g. for OCR
uint16 destGasPerDataAvailabilityByte; // | Amount of gas to charge per byte of message data that needs availability
uint32 destDataAvailabilityOverheadGas; // │ Extra data availability gas charged on top of the message, e.g. for OCR
uint16 destGasPerDataAvailabilityByte; // │ Amount of gas to charge per byte of message data that needs availability
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the not full height comment

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@RensR RensR merged commit 71799d2 into ccip-develop Sep 30, 2024
127 checks passed
@RensR RensR deleted the ccipHome branch September 30, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makramkd makramkd makramkd approved these changes

@connorwstein connorwstein connorwstein approved these changes

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RensR @connorwstein @makramkd