fix when contract reader fails on latestRoundData call #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
reviewed
Oct 1, 2024
| } | ||
|
|
||
| decimalsCR = append(decimalsCR, *decimal) | ||
| } else if read.ReadName == LATEST_ROUND_DATA_METHOD_NAME { | ||
| latestRoundDataRes, ok := val.(*aggregator_v3_interface.LatestRoundData) | ||
| if !ok { | ||
| return fmt.Errorf("expected type latestRoundDataConfig for method call %v on contract %v: %w", batchCalls.latestRoundDataCalls[i/2].MethodName(), batchCalls.latestRoundDataCalls[i/2].ContractAddress(), readErr) | ||
| return fmt.Errorf("expected type latestRoundDataConfig for method call %v on contract %v: %w", batchCalls.latestRoundDataCalls[j].MethodName(), batchCalls.latestRoundDataCalls[j].ContractAddress(), readErr) |
There was a problem hiding this comment.
You could also add an assertion to the top that len(batchCalls.decimalCalls) == len(batchCalls.latestRoundDataCalls)
asoliman92
approved these changes
Oct 2, 2024
dimkouv
approved these changes
Oct 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ccip/core/services/ocr2/plugins/ccip/internal/pricegetter/evm.go
Line 209 in b71329d
This can happen when the contract reader fails on a LatestRoundData call when only one aggregator contract is requested in the batch call.
Solution
Use
read.ReadName