Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Batch1: Adding TOML configs for B^2, BoB, Berachain, Unichain, Worldchain and needed error mappings #1518

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7c1c746
cherry-pick - feat: Add support for parsing deployed 1.0 contracts wh…
AnieeG Aug 27, 2024
5c71121
Bump chain-selectors => v1.0.23 (#1395)
friedemannf Aug 30, 2024
a44b9c2
Fix RPCClient Deadlock on Unsubscribe and NewHead (#14236) (#1426)
0xnogo Sep 11, 2024
22d3d18
Bump version for CCIP 2.14.0-ccip1.5.2
0xnogo Sep 12, 2024
16dda4c
Gas limit estimation feature (#14041)
amit-momin Aug 22, 2024
3290ed3
Set From address for gas limit estimation feature (#14246)
amit-momin Aug 27, 2024
ee84efc
Update EstimateGasLimit config name to EstimateLimit (#14297)
amit-momin Sep 3, 2024
d2cd08f
Add Mantle errors (#14053)
DylanTinianov Aug 8, 2024
1493add
Changed Optimism L1 Oracle to support Mantle (#14160)
ma33r Aug 22, 2024
57e10f6
Mantle use vanilla l1 oracle (#14471)
matYang Sep 18, 2024
74ed3a2
FeeHistory estimator (#13833)
dimriou Sep 4, 2024
11bdcc3
Add node level OOC error (#14315)
friedemannf Sep 5, 2024
7725c8c
Change Polygon zkEVM to use FeeHistory estimator (#14161)
friedemannf Sep 23, 2024
00c81f8
Add Zircuit Configs (#14541)
friedemannf Sep 24, 2024
2f7705c
Use Astar Chain Type (#1465)
flodesi Sep 25, 2024
e8e20f1
Zp/update mockrouter (#1427)
zeuslawyer Sep 12, 2024
da80ec5
Bump version for CCIP 2.14.0-ccip1.5.3
valerii-kabisov-cll Oct 3, 2024
ad546bd
[CCIP-2590] Transfer Data Availability costs to the DAGasEstimator (#…
valerii-kabisov-cll Aug 29, 2024
b84dc2c
[CCIP-3376] Add component into CCIP price estimators to account for c…
valerii-kabisov-cll Sep 24, 2024
b664c36
Revert "Bump version for CCIP 2.14.0-ccip1.5.3"
valerii-kabisov-cll Oct 3, 2024
0d172d1
Bump version for CCIP 2.14.0-ccip1.5.4
valerii-kabisov-cll Oct 3, 2024
943e011
Chore: Change metis config (#1345)
stackman27 Aug 26, 2024
28e5fec
Chore: Metis change (#1485)
stackman27 Oct 4, 2024
047109f
Do not return the error in case if onRamp not initialized (#1487)
valerii-kabisov-cll Oct 4, 2024
890450d
use chain Id as opposed to chain type to identify Mantle (#1489)
matYang Oct 6, 2024
dbe6589
Bump chainselectors cherrypicked (#1493)
fernandezlautaro Oct 8, 2024
5b3e0c2
bump package version
matYang Oct 10, 2024
7711683
updated chain-selectors to 1.0.27 (#1500) (#1502)
simsonraj Oct 15, 2024
a917e9a
Fix Nil pointer error in TXM stuck tx detector (CCIP 1.5) (#1499)
amit-momin Oct 15, 2024
909ecdf
Add Mantle NonceTooLow Error (#14859) (#1505)
matYang Oct 21, 2024
1bb5150
adding configs and error mappings for batch 1
fernandezlautaro Nov 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curly-birds-guess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

Fixed deadlock in RPCClient causing CL Node to stop performing RPC requests for the affected chain #bugfix
5 changes: 5 additions & 0 deletions .changeset/curly-onions-tell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

#changed Make Mantle use default OP stack l1 gas oracle in core
5 changes: 5 additions & 0 deletions .changeset/great-timers-agree.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

Updated gas limit estimation feature to set From address #internal
5 changes: 5 additions & 0 deletions .changeset/green-eagles-deliver.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

Handle zkEVM node level OOC error as TerminallyStuck #internal
5 changes: 5 additions & 0 deletions .changeset/khaki-tigers-agree.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

#added #nops Add Zircuit Configs
5 changes: 5 additions & 0 deletions .changeset/loud-windows-call.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": minor
---

Added gas limit estimation feature to EVM gas estimators. Introduced a new config `EVM.GasEstimator.EstimateLimit` to toggle this feature. #added
5 changes: 5 additions & 0 deletions .changeset/pretty-worms-smell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

Added a custom client error message for Mantle to capture NonceTooLow error. #added
5 changes: 5 additions & 0 deletions .changeset/seven-kiwis-run.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

Added custom client error messages for Mantle to capture InsufficientEth and Fatal errors. #added
5 changes: 5 additions & 0 deletions .changeset/shiny-hornets-pretend.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": minor
---

Introduce new gas estimator #internal
5 changes: 5 additions & 0 deletions .changeset/tender-lemons-obey.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": patch
---

Enable FeeHistory estimator for Polygon zkEVM #nops
5 changes: 5 additions & 0 deletions .changeset/two-mugs-complain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink": minor
---

Edited the Optimism Stack L1 Oracle to add support for Mantle #added
13 changes: 12 additions & 1 deletion .mockery.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ packages:
feeEstimatorClient:
config:
mockname: FeeEstimatorClient
feeHistoryEstimatorClient:
config:
mockname: FeeHistoryEstimatorClient
EvmEstimator:
github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas/rollups:
interfaces:
Expand Down Expand Up @@ -450,7 +453,7 @@ packages:
filename: optimism_portal2_interface.go
outpkg: mock_optimism_portal_2
interfaces:
OptimismPortal2Interface:
OptimismPortal2Interface:
github.com/smartcontractkit/chainlink/v2/core/gethwrappers/liquiditymanager/generated/optimism_dispute_game_factory:
config:
dir: core/gethwrappers/liquiditymanager/mocks/mock_optimism_dispute_game_factory/
Expand Down Expand Up @@ -481,12 +484,20 @@ packages:
PriceRegistryReader:
config:
filename: price_registry_reader_mock.go
FeeEstimatorConfigReader:
config:
filename: fee_estimator_config_mock.go
TokenPoolReader:
config:
filename: token_pool_reader_mock.go
USDCReader:
config:
filename: usdc_reader_mock.go
github.com/smartcontractkit/chainlink/v2/core/services/ocr2/plugins/ccip/estimatorconfig:
interfaces:
GasPriceInterceptor:
config:
filename: gas_price_interceptor_mock.go
github.com/smartcontractkit/chainlink/v2/core/services/ocr2/plugins/ccip/internal/ccipdata/batchreader:
config:
filename: token_pool_batched_reader_mock.go
Expand Down
3 changes: 2 additions & 1 deletion common/fee/models.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ var (
ErrBumpFeeExceedsLimit = errors.New("fee bump exceeds limit")
ErrBump = errors.New("fee bump failed")
ErrConnectivity = errors.New("transaction propagation issue: transactions are not being mined")
ErrFeeLimitTooLow = errors.New("provided fee limit too low")
)

func IsBumpErr(err error) bool {
Expand Down Expand Up @@ -63,7 +64,7 @@ func CalculateBumpedFee(
// Returns highest bumped fee price of originalFeePrice bumped by fixed units or percentage.
func MaxBumpedFee(originalFeePrice *big.Int, feeBumpPercent uint16, feeBumpUnits *big.Int) *big.Int {
return bigmath.Max(
addPercentage(originalFeePrice, feeBumpPercent),
AddPercentage(originalFeePrice, feeBumpPercent),
new(big.Int).Add(originalFeePrice, feeBumpUnits),
)
}
Expand Down
2 changes: 1 addition & 1 deletion common/fee/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func ApplyMultiplier(feeLimit uint64, multiplier float32) (uint64, error) {
}

// Returns the input value increased by the given percentage.
func addPercentage(value *big.Int, percentage uint16) *big.Int {
func AddPercentage(value *big.Int, percentage uint16) *big.Int {
bumped := new(big.Int)
bumped.Mul(value, big.NewInt(int64(100+percentage)))
bumped.Div(bumped, big.NewInt(100))
Expand Down
7 changes: 6 additions & 1 deletion common/txmgr/broadcaster.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"github.com/smartcontractkit/chainlink-common/pkg/utils"

"github.com/smartcontractkit/chainlink/v2/common/client"
commonfee "github.com/smartcontractkit/chainlink/v2/common/fee"
feetypes "github.com/smartcontractkit/chainlink/v2/common/fee/types"
txmgrtypes "github.com/smartcontractkit/chainlink/v2/common/txmgr/types"
"github.com/smartcontractkit/chainlink/v2/common/types"
Expand Down Expand Up @@ -434,7 +435,11 @@ func (eb *Broadcaster[CHAIN_ID, HEAD, ADDR, TX_HASH, BLOCK_HASH, SEQ, FEE]) hand
}

attempt, _, _, retryable, err := eb.NewTxAttempt(ctx, *etx, eb.lggr)
if err != nil {
// Mark transaction as fatal if provided gas limit is set too low
if errors.Is(err, commonfee.ErrFeeLimitTooLow) {
etx.Error = null.StringFrom(commonfee.ErrFeeLimitTooLow.Error())
return eb.saveFatallyErroredTransaction(eb.lggr, etx), false
} else if err != nil {
return fmt.Errorf("processUnstartedTxs failed on NewAttempt: %w", err), retryable
}

Expand Down
Loading
Loading