add context #304
Merged
add context #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
3 times, most recently
from
1dd41d1
to
88cfd02
Compare
|
The linter is very confused. I tried updating to a new version of golangci-lint and using the regular one instead of our custom action, but it is still failing the same way 🤔 |
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
88cfd02
to
95c1ac3
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
36b1bd8
to
88ec42a
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
f85e998
to
ea2dc06
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
67354bd
to
57aca69
Compare
jmank88
commented
Mar 23, 2024
| @@ -28,11 +24,12 @@ require ( | |||
| github.com/beorn7/perks v1.0.1 // indirect | |||
| github.com/bits-and-blooms/bitset v1.10.0 // indirect | |||
| github.com/btcsuite/btcd/btcec/v2 v2.3.2 // indirect | |||
| github.com/btcsuite/btcd/chaincfg/chainhash v1.0.3 // indirect | |||
There was a problem hiding this comment.
Including this line prevents the ambiguous package problem that the btcd replace was addressing.
jmank88
commented
Mar 23, 2024
go.mod
Outdated
| @@ -2,24 +2,20 @@ module github.com/smartcontractkit/chainlink-automation | |||
|
|
|||
| go 1.21 | |||
|
|
|||
| replace ( | |||
| github.com/btcsuite/btcd => github.com/btcsuite/btcd v0.23.3 | |||
| golang/github.com/gogo/protobuf => golang/github.com/gogo/protobuf v1.3.3 | |||
There was a problem hiding this comment.
The protobuf module was unused.
jmank88
commented
Mar 23, 2024
go.mod
Outdated
| golang.org/x/tools v0.15.0 // indirect | ||
| google.golang.org/protobuf v1.31.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| rsc.io/tmplfunc v0.0.3 // indirect | ||
| ) | ||
|
|
||
| exclude golang/github.com/influxdata/influxdb v1.8.3 |
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
eb3df23
to
2240834
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
5583a02
to
1ba5b9d
Compare
This was referenced Jul 30, 2024
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
3 times, most recently
from
f38254c
to
4376363
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
4376363
to
28291d2
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
c651a5b
to
9746144
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
84f4240
to
2458875
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
d5a4d24
to
599dee4
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
0c951d2
to
cf4560b
Compare
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
2 times, most recently
from
b75760c
to
88c427d
Compare
jmank88
commented
Oct 8, 2024
| @@ -49,7 +49,7 @@ jobs: | |||
| go-version-file: "go.mod" | |||
|
|
|||
| - name: Run Unit Tests | |||
| run: go test -v ./... -coverpkg=./... -coverprofile=coverage.txt | |||
There was a problem hiding this comment.
Dropping -v prints only relevant logs, leading to a succinct summary of passing packages, with full logs only for failing tests.
jmank88
force-pushed
the
BCF-2887-context-propagation
branch
from
88c427d
to
d7be4e4
Compare
infiloop2
approved these changes
Oct 9, 2024
krehermann
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/BCF-2887
Requires:
Supports: